Potential texts to externalize #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harown
commented
Nov 23, 2022
| @@ -48,7 +48,7 @@ | |||
|
|
|||
| <!-- a button at the end of each repeating section --> | |||
| <div *ngIf="item._questionRepeatable && lhcDataService.targetShown(item) && !item._isHiddenFromView" class="lhc-button-padding {{lhcDataService.getSkipLogicClass(item)}}"> | |||
| <lhc-button-popover [item]="item" [popoverType]="'repeating-item'" buttonLabel= '+ Add another row of "{{item._text}}"' [append]="true"></lhc-button-popover> | |||
| <lhc-button-popover [item]="item" [popoverType]="'repeating-item'" buttonLabel= '+' [append]="true"></lhc-button-popover> | |||
There was a problem hiding this comment.
Our project managers just wanted a "+" char here, so we omitted the text.
There was a problem hiding this comment.
I believe I have already made this change, but it must not be merged yet.
Harown
commented
Nov 23, 2022
| } | ||
| // INT, ST, DT, TM and CNE | ||
| else { | ||
| if (item.externallyDefined) | ||
| item._placeholder = item._multipleAnswers ? "Search for values" : "Search for value"; | ||
| item._placeholder = "Suchen"; |
|
Thanks -- this is helpful. I will leave this open until we can get some configuration file(s) for these changes in place. |
|
Forget to mention 2 more occurences. Both are in the
German sparrows chirped the gevko is commissioned with the German translations. 🙂 |
Harown
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@plynchnlm This refers to #70 (comment).
Happy to get this PR rejected 😄