Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make optional properties of bindings nullable #89

Merged
merged 25 commits into from
Mar 1, 2023
Merged

fix: make optional properties of bindings nullable #89

merged 25 commits into from
Mar 1, 2023

Conversation

ullebe1
Copy link
Contributor

@ullebe1 ullebe1 commented Feb 8, 2023

Makes all properties of bindings that are optional nullable, so as to make them optional in the library as well.

@ullebe1 ullebe1 requested a review from VisualBean as a code owner February 8, 2023 09:38
github-actions[bot]
github-actions bot reviewed Feb 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ullebe1 for your first pull request to AsyncAPI.NET repository. Please check out our contributors guide.

@github-actions github-actions bot added asyncapi.tests documentation Improvements or additions to documentation and removed asyncapi.tests labels Feb 9, 2023
@ullebe1 ullebe1 force-pushed the ullebe1/optionals_nullable branch from b01e212 to 80e7258 Compare February 9, 2023 12:51
@github-actions github-actions bot removed asyncapi.tests documentation Improvements or additions to documentation labels Feb 9, 2023
@ullebe1
Copy link
Contributor Author

ullebe1 commented Feb 28, 2023

Reverted the commit putting the versions in quotes in strings. Seems there is something inconsistent in how that works. On my machine they need to be in quotes for the tests to pass, in CI they cannot be in quotes or the tests fail. No special setup, just running dotnet test.

VisualBean
VisualBean approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@VisualBean VisualBean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 👍

@VisualBean
Copy link
Collaborator

This change will be a part of the 3.0 release

@VisualBean VisualBean merged commit 499cf64 into main Mar 1, 2023
@VisualBean VisualBean deleted the ullebe1/optionals_nullable branch March 1, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@VisualBean VisualBean VisualBean approved these changes

Assignees
No one assigned
Labels
asyncapi.models asyncapi.readers asyncapi.tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ullebe1 @VisualBean