feat: targetframework to netstandard2.0 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows it to be used by any project type rather then just .netframework
Added new unit test to validate the special characters string extensions, which was failing tests
github-actions
bot
added
asyncapi.models
asyncapi.readers
asyncapi.tests
asyncapi.bindings
labels
ByronMayne
commented
Mar 12, 2024
test/LEGO.AsyncAPI.Tests/Writers/SpecialCharacterStringExtensionsTests.cs
Outdated
Show resolved
Hide resolved
VisualBean
reviewed
Mar 12, 2024
|
Everything should be good now |
ByronMayne
changed the title
looks like you kept the test changes around as well. |
|
Sorry about that, it was collapsed and I miss it in the visuals. |
Took me a double take, to find it as well 😅 no worries! |
VisualBean
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Changed the project to target
.netstandard2.0instead of.net6.0