Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing mapping for ordering #138

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

gokerakc
Copy link
Contributor

About the PR

sns ordering property is not getting parsed due to the missing mapping.

Changelog

  • Fix: Added missing mapping for sns ordering property

@gokerakc gokerakc requested a review from VisualBean as a code owner December 14, 2023 10:42
@gokerakc gokerakc changed the title fix: Added missing mapping for ordering fix: added missing mapping for ordering Dec 14, 2023
@gokerakc
Copy link
Contributor Author

gokerakc commented Dec 14, 2023

FYI, this unit test is supposed to catch that null ordering value but it seems like it's not working as expected. We need to cast the binding object as SnsChannelBinding before the assertion. Please check my changes here

@gokerakc
Copy link
Contributor Author

gokerakc commented Dec 14, 2023

If it's possible please merge this in then we can create another PR to update the other unit tests. There are several places where the method .BeEquivalentTo() is used.

@VisualBean VisualBean merged commit 510426e into LEGO:main Dec 14, 2023
5 checks passed
@gokerakc gokerakc deleted the fix_SnsOrderingParse branch February 12, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants