fix: async schema deserializer "additionalProperties" not deserializing JsonSchema correctly #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you UlrikSandberg for your first pull request to AsyncAPI.NET repository. Please check out our contributors guide.
UlrikSandberg
changed the title
VisualBean
approved these changes
Jul 11, 2023
VisualBean
approved these changes
Jul 11, 2023
VisualBean
changed the title
VisualBean
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Additional properties field of the async spec were experiencing a bug. Having the "additionalProperties" present caused the library to throw an Error as the MapNode didn't implement GetBooleanValueOrDefault and the code thus defaulted to the abstract ParseNode implementation which throw an exception.
This PR tries to cast the node to a ValueNode before calling GetBooleanValueOrDefault else the already existing behaviour.
Unit test to accommodate the change.
Changelog