Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: separate bindings and allow for custom bindings. #107

Merged
merged 17 commits into from
May 3, 2023

Conversation

VisualBean
Copy link
Collaborator

@VisualBean VisualBean commented Apr 26, 2023

This PR moves Bindings into their own package (LEGO.AsyncAPI.Bindings)

BREAKING CHANGE: Moves bindings support to their own package.

For Writing, the support is the same, simply add the binding where applicable.
For Reading support has changed, as they arent implicitly added.

Binding support must be added explicitly to the reader through the settings.
A static helper has been made, to make this slightly easier, however.

var settings = new AsyncApiReaderSettings();
settings.Bindings.AddRange(BindingsCollection.All);
var reader = new AsyncApiStringReader(settings);

@VisualBean VisualBean changed the title feat: Separate bindings and allow for custom bindings. feat: separate bindings and allow for custom bindings. Apr 26, 2023
@dpwdec
Copy link
Contributor

dpwdec commented May 1, 2023

Nice work man! I guess I will act as a “QA” for this when I integrate it into the AWS bindings work. As ever appreciate you getting so much done on this so quickly! 🙏

src/LEGO.AsyncAPI.Bindings/ChannelBinding{T}.cs Outdated Show resolved Hide resolved
src/LEGO.AsyncAPI.Bindings/MessageBinding{T}.cs Outdated Show resolved Hide resolved
src/LEGO.AsyncAPI.Bindings/OperationBinding{T}.cs Outdated Show resolved Hide resolved
src/LEGO.AsyncAPI.Bindings/Pulsar/PulsarChannelBinding.cs Outdated Show resolved Hide resolved
src/LEGO.AsyncAPI.Bindings/ServerBinding{T}.cs Outdated Show resolved Hide resolved
src/LEGO.AsyncAPI.Readers/Interface/IBindingParser1.cs Outdated Show resolved Hide resolved
src/LEGO.AsyncAPI.Readers/ParseNodes/FixedFieldMap.cs Outdated Show resolved Hide resolved
src/LEGO.AsyncAPI/Models/ReferenceType.cs Outdated Show resolved Hide resolved
@VisualBean VisualBean marked this pull request as ready for review May 2, 2023 07:34
@github-actions github-actions bot added the ci/cd label May 2, 2023
@VisualBean VisualBean changed the title feat: separate bindings and allow for custom bindings. feat!: separate bindings and allow for custom bindings. May 2, 2023
@VisualBean VisualBean merged commit 861ee6f into main May 3, 2023
@VisualBean VisualBean deleted the alex-bindingstake2 branch May 3, 2023 06:44
VisualBean added a commit that referenced this pull request Jun 5, 2023
BREAKING CHANGE: Bindings have been moved to a separate project
VisualBean added a commit that referenced this pull request Jun 7, 2023
BREAKING CHANGE: Bindings have been moved to a separate project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants