forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Replaces `sass-lint` with `stylelint` * Introduces standard scss rules from stylelint with only a few modifications. * `yarn lint` now runs `yarn lint:style` instead of `yarn lint:sass`. * Many of the files were updated with `yarn lint:style --fix`, but some of them had to be manually updated with overrides to adhere to the newly-introduced rules from the stylelint configuration. * Includes a couple fixes such as fixing the class selector for `osdnSuggestionItem--value .osdSuggestionItem__text`. Resolves opensearch-project#551 Resolves opensearch-project#1139 Resolves opensearch-project#1151 Resolves opensearch-project#1152 Resolves opensearch-project#1154 Signed-off-by: Tommy Markley <[email protected]> * fix(Style): Fixes flex style Signed-off-by: Ashwin Pc <[email protected]> * fix(lint): Fixes empty comment lint issue Signed-off-by: Ashwin Pc <[email protected]> * chore: rebase and updates yarn.lock Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Tommy Markley <[email protected]>
- Loading branch information
Showing
240 changed files
with
1,400 additions
and
1,552 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# use stylelint | ||
*.scss |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
build | ||
target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
extends: | ||
- stylelint-config-standard-scss | ||
rules: | ||
# while we still use node-sass, only legacy rgb() notation is allowed | ||
color-function-notation: "legacy" | ||
# recommended to turn off descending specificity since we use a lot of nesting: | ||
# https://stylelint.io/user-guide/rules/list/no-descending-specificity/ | ||
no-descending-specificity: null | ||
# need to use global function/value names from EUI | ||
function-name-case: null | ||
value-keyword-case: null | ||
scss/no-global-function-names: null | ||
# camelCase names | ||
keyframes-name-pattern: "^[a-z][a-zA-Z0-9_-]+$" | ||
selector-class-pattern: "^[a-z][a-zA-Z0-9_-]+$" | ||
selector-id-pattern: "^[a-z][a-zA-Z0-9_-]+$" | ||
scss/at-mixin-pattern: "^[a-z][a-zA-Z0-9_-]+$" | ||
scss/at-function-pattern: "^[a-z][a-zA-Z0-9_-]+$" | ||
scss/dollar-variable-pattern: "^[a-z][a-zA-Z0-9_-]+$" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
/* stylelint-disable no-empty-source */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/osd-optimizer/src/__fixtures__/mock_repo/plugins/bar/public/legacy/styles.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
@import "./other_styles.scss"; | ||
@import "./other_styles"; | ||
|
||
body { | ||
width: $globalStyleConstant; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
/* stylelint-disable no-empty-source */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/osd-ui-framework/doc_site/src/components/guide_code/_guide_code.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
.guideCode { | ||
padding: 2px 4px; | ||
font-family: 'Ubuntu Mono', monospace; | ||
font-family: "Ubuntu Mono", monospace; | ||
background-color: $euiColorLightestShade; | ||
color: $euiColorDarkShade; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.