add timeouts to QA search #2583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
force-pushed
the
2182-search-timeouts
branch
from
25005a8
to
27a1e87
Compare
|
Using this technique for timeing out the fetch calls: whatwg/fetch#951 (comment) |
peetucket
force-pushed
the
2182-search-timeouts
branch
from
27a1e87
to
d307faa
Compare
peetucket
force-pushed
the
2182-search-timeouts
branch
from
37452d0
to
7ea0783
Compare
peetucket
force-pushed
the
2182-search-timeouts
branch
2 times, most recently
from
cbbc73f
to
f5590a9
Compare
|
We decided not to pursue this any further unless it becomes a bug report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
Addresses part of #2182 (search timeouts)
Search spinner is in #2567
This is the timeout error message (not great, but matches the error message style you get for other search messages, and a custom message will potentially be substantially more work to implement):
How was this change tested?
Updated tests
Which documentation and/or configurations were updated?