Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sparsevec #783

Merged
merged 2 commits into from
May 11, 2023
Merged

fix sparsevec #783

merged 2 commits into from
May 11, 2023

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented May 11, 2023

No description provided.

@exaexa exaexa added the bug Something isn't working label May 11, 2023
@exaexa exaexa requested a review from stelmo May 11, 2023 07:45
@exaexa
Copy link
Collaborator Author

exaexa commented May 11, 2023

@stelmo there are 2 other sparsevec instances in community models, can you have a look if they actually do what they are supposed to do? The problem is that sparsevec([],[],...) has defaulted to a sparse vector of Anys, which don't have a default zero, thus allocation of anything breaks.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c510103) 91.39% compared to head (1bebba9) 91.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #783   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          86       86           
  Lines        2209     2209           
=======================================
  Hits         2019     2019           
  Misses        190      190           
Impacted Files Coverage Δ
src/base/types/SBMLModel.jl 92.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@exaexa exaexa merged commit 99b3002 into master May 11, 2023
@exaexa exaexa deleted the mk-fix-sparsevec branch May 11, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants