Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing and segfaulting tests #711

Merged
merged 4 commits into from
Feb 10, 2022

Conversation

haasad
Copy link
Member

@haasad haasad commented Feb 10, 2022

This PR includes the following chagnes:

  • explicitly skip failing presamples tests instead of just commenting them out (otherwise they're likely forgotten)
  • skip 2 tests on osx that lead to segfaults
    • there might be more, but it's unclear to me what exactly causes the segfaults
    • re-running the workflow sometimes doesn't segfault
  • add some additional output in the pipeline to help debug dependecy problems and upload an export of the final environment as artifact

I'll create a separate issues for fixing the dependencies, there's something pretty broken atm. But with the changes in this PR it should at least be possible to release a new working version so people don't have broken installations when installing/updating the AB.

Relates: #707

@haasad haasad mentioned this pull request Feb 10, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.078% when pulling b5c8a36 on haasad:i707/fix-release into 8d9f44a on LCA-ActivityBrowser:master.

@bsteubing bsteubing merged commit b957bf0 into LCA-ActivityBrowser:master Feb 10, 2022
@bsteubing
Copy link
Member

Excellent - thanks so much @haasad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants