Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS Dark theme compatibility #1374

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

marc-vdm
Copy link
Member

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@coveralls
Copy link

Coverage Status

coverage: 54.266% (+0.03%) from 54.233%
when pulling c02ad24 on marc-vdm:dark_theme_settings
into 6ebca06 on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm added this to the 2.10.3 milestone Sep 25, 2024
@mrvisscher
Copy link
Collaborator

Is there a way to not have to reload the AB? Like setting the style_item singleton

@mrvisscher mrvisscher marked this pull request as ready for review September 25, 2024 15:03
@mrvisscher mrvisscher merged commit 5fb047b into LCA-ActivityBrowser:main Sep 25, 2024
9 checks passed
This was referenced Sep 25, 2024
@marc-vdm marc-vdm deleted the dark_theme_settings branch September 25, 2024 15:17
@marc-vdm marc-vdm added the change PRs related to minor changes to AB label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change PRs related to minor changes to AB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants