Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better plugin logging #1347

Merged

Conversation

marc-vdm
Copy link
Member

AB now better communicates what is going on when loading plugins

+ refactor of load to import (as we imported from the python env with this function) and add to load (as we called the plugin.load() function in the plugin)

+ More consistent closing and removing of plugins when needed

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@marc-vdm marc-vdm added the change PRs related to minor changes to AB label Aug 27, 2024
@marc-vdm marc-vdm added this to the 2.10.2 milestone Aug 27, 2024
@coveralls
Copy link

coveralls commented Aug 27, 2024

Coverage Status

coverage: 54.085% (-0.05%) from 54.132%
when pulling 52d0a74 on marc-vdm:plugin-import-improvement
into f28bdbd on LCA-ActivityBrowser:main.

@mrvisscher mrvisscher merged commit da34ce9 into LCA-ActivityBrowser:main Sep 16, 2024
9 checks passed
@marc-vdm marc-vdm deleted the plugin-import-improvement branch September 17, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change PRs related to minor changes to AB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants