Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the dependent biosphere database visible in the CF table #1341

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Aug 13, 2024

Because the biosphere3 database isn't necessarily the only elementary flow database anymore, it is necessary to show what database the characterization factor in the CF table is from. This PR enables that functionality.

image

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the change PRs related to minor changes to AB label Aug 13, 2024
@mrvisscher mrvisscher modified the milestones: 2.10.1, 2.10.2 Aug 13, 2024
@coveralls
Copy link

Coverage Status

coverage: 54.132%. remained the same
when pulling 89f28fa on mrvisscher:visible-db-for-cf
into f28bdbd on LCA-ActivityBrowser:main.

Copy link
Member

@marc-vdm marc-vdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move the col to after Unit as this is not so important information but then LGTM

@mrvisscher mrvisscher merged commit 09c5a30 into LCA-ActivityBrowser:main Sep 16, 2024
9 checks passed
@mrvisscher mrvisscher deleted the visible-db-for-cf branch November 8, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change PRs related to minor changes to AB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants