-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving GUI out of the controllers #1241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also some documentation TODO:
- Make contributing.md a smaller file with references the below:
- Add files explaining important items (file for actions, controllers, signals etc)
- Why do they exist?
- When (not) to use them?
- Relationships between other things
- File on how to update tests
@@ -95,6 +95,6 @@ def focusOutEvent(self, event): | |||
super(SignalledComboEdit, self).focusOutEvent(event) | |||
|
|||
# def showPopup(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
|
||
# | ||
# | ||
# def test_open_db_wizard_button(qtbot, ab_app, monkeypatch): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
Big refactor that moves GUI interaction out of the controllers and into specialized
ABAction
's. This introduces a new design philosophy in which widgets are only responsible for their own state, controllers are only responsible for Brightway's state, and actions are responsible for the logic for moving between states. This:ABAction flowchart
Checklist
bug
,feature
,ui
,change
,documentation
,breaking
,ci
as they show up in the changelog.