Reference flows equal to 0 aren't allowed to calculate anymore. #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the parameter scenario files.
How to install using Mamba
…es (LCA-ActivityBrowser#1069) * Updates to the functions from de Koning (get_relevant_flows and get_relevant_activities), avoiding use of pandas apply and using python map functionality for splitting pandas dataframes. * Update the use of DataFrame.applymap to DataFrame.map in the excel file importer module.
* Updates to the logging system to avoid the print statement. Merging with commits for corrections to the uncertainty distributions that were included within the same branch. Improves thread safety in logging increasing stability in the multi-threaded processes. * Changes the creation of log files. Amends the uncertainty wizard test to correct for use of logging over the standard console. Adds the .logs to .gitignore. * 1) Simplifies the use of the python logging facility with QtThreads (as published on the python docs for logging), improving the stability of logging.\n2) Changes the generation of the logging object that is more compatible with pytest, supporting the existing test procedures. * Provides an update to the Model for the calculation_setup Methods table, corrects for deletion of impact assessment methods. Updates the routine to the lca_setup module for calling the logger. * Updates to the logger module, what was the ABLogger class is renamed to ABHandler. The module now contains the formats and settings for the Stream handlers. Calling of the methods in the other AB modules requires passing a logging.Logger instance and the name of the calling module. These are then incorporated into the wrapping routines in the class. Additions:\n 1) An error wrapper is provided and also explicitly provides a trace of the error.\n 2) A timestamp routine is provided and used for providing the file names for log files.\n 3) A standard location based on appdirs is provided and used for log file locations. * Corrections to the setup of the logger in the test_uncertainty_wizard module * Includes a change to the type used for the scenario columns when using multiple files with the combined (combinatoric) approach for the scenarios. Includes respective changes to the boolean tests applied to such Indexes. * Minor corrections to local repository branch, to keep changes aligned * Alterations to keep minor changes aligned with master branch and fork --------- Co-authored-by: zoo <[email protected]>
This was added before brightway2 supported multi-arch builds on conda-forge. It is not needed anymore, because the normal AB is now also installable on arm arch.
* Increase timeout to 30 min Originally the idea was that installation should never take longer than 12 min, otherwise we should get a warning with the failed pipeline. But unfortuantely conda currently takes longer than 12 minutes to solve the environment. * Add mamba install canary * Download artifacts to start implementing env comparison * Looks like on linux it can take more than 30 minutes :-( * 60min not enough on linux, increasing to 120 * Completely remove timeout, default is 6 hours * Use solver libmamba option * Add diff step to compare installations * Use node16 actions * Re-add the 12 timeout * Split diff into separate steps * Yq action only runs on linux * debug yq formatting step * Simplify * more fighting with yq action * artifacts are apparently directories in this case * Try again with while loop * Run on all os, but only 3.9 * ignore diff exit code * Run canary install for 3.8 and 3.9 again --------- Co-authored-by: haasad <[email protected]>
* Switch project on delete LCA-ActivityBrowser#1075 * Cleaning up ProjectController.change_project * Resolving comments by marc-vdm
…ity-browser � Conflicts: � .github/PULL_REQUEST_TEMPLATE.md
Auto point to new release
GH action script for commenting on issues when related milestone is c…
GH action script for commenting on issues when related milestone is c…
GH action script for commenting on issues when related milestone is c…
Automated review instructions
review instructions bot
mrvisscher
reviewed
Dec 18, 2023
|
This issue has been implemented in the new release of Activity Browser 🚀 (version 2.9.3), you can get the new version by updating Activity Browser. 🤖beep boop! I'm a bot and this message was an automated action. If updating does not make sense for this issue, just ignore this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not allowed for the sum of reference flows in a calculation setup to be equal to 0. This was an error.
AB should instead check for reference flows that are 0 themselves (needing 0 of something will by definition have 0 impact, so should not be allowed in calculation).
AB now checks for any ==0 reference flows and shows an appropriate error message informing user.
Checklist
bug,feature,ui,change,documentation,breaking,cias they show up in the changelog.