Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better biosphere install/update handling #1145

Merged
merged 101 commits into from
Dec 13, 2023

Conversation

marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Nov 30, 2023

Feature

  1. When user starts a new project, user can now choose which version of ecoinvent the biosphere database should be compatible with:
  • image
  • If the newest Major/Minor (e.g. 3.9) is chosen, biosphere is installed from bw2io
  • If an older version is chosen (e.g. 3.7), AB installs a legacy version of biosphere and applies patches (if needed) to update to the version requested.
  1. When user chooses to update biosphere, the same popup as above is shown, allowing user to choose to what version to update. Note that downgrading to older versions is not supported.
  • image
  1. When user installs an ecoinvent version from online, user can only choose versions explicitly supported by AB
  • image
  1. AB now has a list with explicit support for ecoinvent versions per AB version.
  • Users will not be able to see newer versions that are not supported
  • The file is stored online, with local fallback
  • If ecoinvent would release a new version of ecoinvent (e.g. a patch version), only the online file needs to be updated, users wouldn't need to update AB.
  • Local fallback still allows updating biosphere to work without internet connection
  1. AB now stores legacy versions of biosphere for ecoinvent 3.4, 3.5 and 3.6 locally (~1MB compressed size in total), for 3.7 and 3.8 AB will install 3.6 and apply patch updates from bw2io to the correct version.

Implementation of #1142, but will also partly help (though not entirely resolve) #1137

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog
  • Link this PR to related issues by using closing keywords.
  • Request a review from another developer.

@marc-vdm marc-vdm added the change PRs related to minor changes to AB label Nov 30, 2023
@coveralls
Copy link

coveralls commented Dec 3, 2023

Coverage Status

coverage: 50.424% (+0.4%) from 50.055%
when pulling a03cb71 on marc-vdm:better_biosphere_handling
into d5b9e75 on LCA-ActivityBrowser:master.

@marc-vdm marc-vdm added this to the 2.9.3 milestone Dec 3, 2023
@marc-vdm marc-vdm marked this pull request as ready for review December 3, 2023 10:45
mrvisscher and others added 19 commits December 4, 2023 20:18
* Switch project on delete LCA-ActivityBrowser#1075

* Cleaning up ProjectController.change_project

* Resolving comments by marc-vdm
GH action script for commenting on issues when related milestone is c…
GH action script for commenting on issues when related milestone is c…
GH action script for commenting on issues when related milestone is c…
Automated review instructions
@marc-vdm marc-vdm merged commit a7313e0 into LCA-ActivityBrowser:master Dec 13, 2023
12 checks passed
Copy link

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.9.3), you can get the new version by updating Activity Browser.

🤖beep boop! I'm a bot and this message was an automated action. If updating does not make sense for this issue, just ignore this.

@marc-vdm marc-vdm deleted the better_biosphere_handling branch May 14, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change PRs related to minor changes to AB
Projects
None yet
6 participants