Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper sorting of available ecoinvent versions #1141

Closed

Conversation

marc-vdm
Copy link
Member

DO NOT MERGE THIS BEFORE ECOINVENT 3.10 IS SUPPORTED IN AB

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog
  • Link this PR to related issues by using closing keywords.
  • Request a review from another developer.
  • Add milestone once ei 3.10 is supported in AB

@marc-vdm marc-vdm added the bug Issues/PRs related to bugs label Nov 29, 2023
@coveralls
Copy link

Coverage Status

coverage: 50.029% (-0.004%) from 50.033%
when pulling 897cc2c on marc-vdm:ecoinvent_version_sort
into fe69950 on LCA-ActivityBrowser:master.

@marc-vdm marc-vdm mentioned this pull request Nov 29, 2023
10 tasks
@marc-vdm
Copy link
Member Author

Closing in favour of developments for #1142

@marc-vdm marc-vdm closed this Nov 30, 2023
@marc-vdm marc-vdm deleted the ecoinvent_version_sort branch May 14, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort available ecoinvent databases based on number instead of as str
2 participants