Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip to table cells with content overflow #1130

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Nov 17, 2023

Enables users to view a table cell's contents by hovering their pointer over the table cell. If there is an overflow in said cell (i.e. the text is wrapped / cut short with a ...) the full text is shown in a tooltip.

Screenshot of Feature

tooltipscreenshot

Notes

  • This doesn't apply to headers of tables.
  • This will overrule other tooltips set higher in the qt hierarchy, but only if there is an overflow of the table cell in question.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog
  • Link this PR to related issues by using closing keywords.
  • Request a review from another developer.

@mrvisscher mrvisscher added the feature Issues/PRs related to a new feature label Nov 17, 2023
@coveralls
Copy link

Coverage Status

coverage: 50.051% (-0.02%) from 50.066%
when pulling 07cd9ef on mrvisscher:table-tooltip
into c722b17 on LCA-ActivityBrowser:master.

@marc-vdm marc-vdm added this to the 2.9.3 milestone Nov 17, 2023
@marc-vdm marc-vdm added change PRs related to minor changes to AB and removed feature Issues/PRs related to a new feature labels Nov 17, 2023
Copy link
Member

@marc-vdm marc-vdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@marc-vdm marc-vdm merged commit d23a9d2 into LCA-ActivityBrowser:master Nov 17, 2023
9 checks passed
@mrvisscher mrvisscher deleted the table-tooltip branch November 29, 2023 12:21
Copy link

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.9.3), you can get the new version by updating Activity Browser.

🤖beep boop! I'm a bot and this message was an automated action. If updating does not make sense for this issue, just ignore this.

@marc-vdm marc-vdm mentioned this pull request Jun 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change PRs related to minor changes to AB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All tables: show full cell content as tooltip on hover
3 participants