Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and improved documentation for contributing to AB #1088

Merged

Conversation

marc-vdm
Copy link
Member

Updated and improved file for contributing to AB

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog

@marc-vdm marc-vdm added the documentation PRs that refer to documentation at any level (code, readthedocs, etc.) label Oct 23, 2023
@marc-vdm marc-vdm added this to the 2.9.3 milestone Oct 23, 2023
@coveralls
Copy link

coveralls commented Oct 23, 2023

Coverage Status

coverage: 50.184%. remained the same when pulling af1dd6a on marc-vdm:improved_contributing_file into 5a953a0 on LCA-ActivityBrowser:master.

@marc-vdm
Copy link
Member Author

marc-vdm commented Oct 23, 2023

@bsteubing, the new guidelines can be seen as formatted MarkDown here: CONTRIBUTING.md.

Just let me know if you think changes need to be made or otherwise merge this PR :)

@marc-vdm
Copy link
Member Author

@bsteubing Pinging you if you could please review CONTRIBUTING.md.

@bsteubing
Copy link
Member

This looks very good - even the new version release instructions - well done!! :-)

@marc-vdm marc-vdm merged commit 61bf99e into LCA-ActivityBrowser:master Nov 2, 2023
10 checks passed
Copy link

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.9.3), you can get the new version by updating Activity Browser.

🤖beep boop! I'm a bot and this message was an automated action. If updating does not make sense for this issue, just ignore this.

@marc-vdm marc-vdm deleted the improved_contributing_file branch May 14, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation PRs that refer to documentation at any level (code, readthedocs, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants