Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic examples in how-to #24

Open
3 tasks
sariths opened this issue Aug 4, 2023 · 4 comments
Open
3 tasks

Added basic examples in how-to #24

sariths opened this issue Aug 4, 2023 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@sariths
Copy link
Contributor

sariths commented Aug 4, 2023

Add examples for rtrace, rpict and rfluxmtx.

  • rpict
  • rtrace
  • rflutxmtx

@taoning I added a discussion regarding the choice of input files here: #23

@sariths sariths added the documentation Improvements or additions to documentation label Aug 4, 2023
@sariths sariths self-assigned this Aug 4, 2023
@sariths
Copy link
Contributor Author

sariths commented Aug 4, 2023

@taoning
Copy link
Collaborator

taoning commented Aug 5, 2023

Looks good. Instead of write_to_file, maybe just write? I think we have file_path as the first argument, followed by data?

If the sky source is used for an octree, we can just feed the bytes to stdin in oconv rather than write to a file first.

In terms of sampling parameters, we can do

params = SamplingParamters()
params.update_from_dict({"-ab":1})
params.ad = 256
params.lw = 1 / params.ad
rpict(..., params=params.args())

Is this similar to what you have in mind?

@sariths
Copy link
Contributor Author

sariths commented Aug 5, 2023 via email

@taoning
Copy link
Collaborator

taoning commented Aug 5, 2023

Sure, we can add those tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants