Pass wavelengths to color calculations

[vidanovic]

Make sure to pass wavelength to color calculation since that is consistent with rest of the methods. Now, color calculations are using wavelenghts from the materials which does not sound correct.

[RDmitchell]

Do you need to run this by Jacob or Charlie to verify the correct procedure ? Just curious.

…

On Thu, Aug 18, 2022 at 9:34 AM Simon Vidanovic ***@***.***> wrote: Make sure to pass wavelength to color calculation since that is consistent with rest of the methods. Now, color calculations are using wavelenghts from the materials which does not sound correct. — Reply to this email directly, view it on GitHub <#135>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQFXRQOYFWU3B62QO7U7YLVZZQ2VANCNFSM565Z3QNQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Robin Mitchell Building Technology and Urban Systems Division Energy Technologies Area Lawrence Berkeley National Laboratory

[jcjonsson]

Gang, I think Simon is doing the right thing. I reviewed ASTM E308 and it allows for calculation of data not obtained at 5nm intervals but it is quite cumbersome (it looks like you have to use different illuminant and detector spectra rather than just using the data in the 5nm spectra where you have sample data). It is also restrictive in that it has to be 10 nm or 20 nm steps, not a mix, and no other step size, so our old wavelength definition is not allowed (the one with 121 wavelengths used in clear_3.dat e.g.). This is how it was set up in W5_NFRC_2003.std: Wavelength Set : Color 5nm.wvl It makes sense to me as it is technically better than the standard (doing interpolation of data to the high resolution illuminant and detector spectra instead of using other tables for low res data). Best, Jacob

…

On 10/11/2022 2:00 AM, RDmitchell wrote: Do you need to run this by Jacob or Charlie to verify the correct procedure ? Just curious. On Thu, Aug 18, 2022 at 9:34 AM Simon Vidanovic ***@***.***> wrote: > Make sure to pass wavelength to color calculation since that is consistent > with rest of the methods. Now, color calculations are using wavelenghts > from the materials which does not sound correct. > > — > Reply to this email directly, view it on GitHub > <#135>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABQFXRQOYFWU3B62QO7U7YLVZZQ2VANCNFSM565Z3QNQ> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- Robin Mitchell Building Technology and Urban Systems Division Energy Technologies Area Lawrence Berkeley National Laboratory — Reply to this email directly, view it on GitHub <#135 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE3LUUJA44J2S47OSI3JV6TWCUUBDANCNFSM565Z3QNQ>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[vidanovic]

@RDmitchell This is just a notification for me to check if wavelengths used in color procedures are passed correctly. I stumble into this while optimizing code recently and it is good to check.