This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Fixes intermittent issues with Cypress tests #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-davies
commented
Jun 11, 2020
| @@ -66,6 +56,7 @@ context('Add action form', () => { | |||
| ); | |||
|
|
|||
| cy.get('[data-testid=add-action-button-test]').click(); | |||
| cy.get('[data-testid=add-action-button-test]').should('not.exist'); | |||
There was a problem hiding this comment.
Waits for the button to disappear, since this is hidden after the API call has completed so we know we should be done waiting for it.
|
Let's give it a go! |
mmmmillar
approved these changes
Jun 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes and workarounds for some intermittent problems with our Cypress tests. It is likely this is caused by the page being updated in the background and then the DOM element Cypress is referring to becoming detached from the document, since it has been replaced. There is a proposal to have Cypress requery in these cases over at cypress-io/cypress#7306.
Why
So that we can have better confidence in our tests, and do not get into the habit of just re-running them when there is a failure.
Anything else?