Use the tool with the highest similarity instead of the first one over 75% #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someone13574
requested review from
yk,
andreaskoepf,
olliestanley and
AbdBarho
as code owners
olliestanley
reviewed
May 9, 2023
inference/worker/chat_chain_utils.py
Outdated
| @@ -162,12 +162,17 @@ def prepare_json(json_str: str) -> str: | |||
|
|
|||
|
|
|||
| def use_tool(tool_name: str, tool_input: str, tools: list) -> str: | |||
| best_match = None | |||
There was a problem hiding this comment.
This code could just be something like:
best_match, best_similarity = max(
((tool, similarity(tool.name, tool_name)) for tool in tools),
key=lambda x: x[1],
default=(None, 0),
)
olliestanley
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.