fix: catch undocumented edge case in scandir() #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While libuv/vim.loop docs say that `fs_scandir_next()` either returns `nil` or `string, string` or fails, there is an edge case on networked filesystems. In those cases, `uv__fs_scandir()` returns the type `UV_DIRENT_UNKNOWN` and `luv.fs_scandir_next()` [converts][1] this into returning a single string. This means in those cases, `name` is a string and `type` is `nil`. See [this bug report][2]. The situation can be remedied by explicitly calling `fs_stat()` on those files. This always fetches the correct type, as far as I can see. [1]: https://github.com/luvit/luv/blob/master/src/fs.c#L116 [2]: luvit/luv#660
|
Damn, that's a clean PR👌👌👌👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While libuv/vim.loop docs say that
fs_scandir_next()either returnsnilorstring, stringor fails, there is an edge case on networked filesystems. In those cases,uv__fs_scandir()returns the typeUV_DIRENT_UNKNOWNandluv.fs_scandir_next()converts this into returning a single string.This means in those cases,
nameis a string andtypeisnil. See the upstream bug report.The situation can be remedied by explicitly calling
fs_stat()on those files. This always fetches the correct type, as far as I can see.PS: Thanks for this awesome plugin! 🙂