Implement more trigger-types #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
|
maybe just use 'trigger' instead of |
|
Oh I like trigEngine, ty👍👍 |
L3MON4D3
force-pushed
the
trigger-types
branch
6 times, most recently
from
34dd25b
to
ed6c108
Compare
|
Alright, this should be it. |
Check `trigEngine` in `:h luasnip-snippets`, or in `DOC.md`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new option,
trigMatcher, which determines how the trigger is matched to the current line.I've veered from calling it
trigType, since it sounds like it would only accepts a string, whereas I'd like to make it possible to completely customize the trigger-matching by passing a function.So, currently,
trigMatcheraccepts either a function (then uses that), a string (any from "plain", "pattern", "vim", "ecma" for plain strings, lua-patterns, vim-regex and ecma-regex respectively (the last two are not yet implemented)). IftrigMatcheris not set at all, we look ifregTrigis set and use "pattern" if it is, and if that is not set as well, we fall back to "plain".I think this will also deprecate
regTrigsince that name was misleading from the start (but a very soft deprecation, I don't think we will actually remove it)I'm not completely convinced by the name
trigMatcher, if somebody has a different idea, mention it :D