Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add default condition for postfix #898

Merged
merged 3 commits into from
May 26, 2023
Merged

feat: add default condition for postfix #898

merged 3 commits into from
May 26, 2023

Conversation

MunifTanjim
Copy link
Contributor

@MunifTanjim MunifTanjim force-pushed the feat-postfix-default-cond branch 2 times, most recently from 6172a22 to dd03865 Compare May 26, 2023 07:23
@L3MON4D3
Copy link
Owner

Nice, thank you for doing the PR 👍

@MunifTanjim MunifTanjim force-pushed the feat-postfix-default-cond branch 6 times, most recently from b9d0694 to fd92120 Compare May 26, 2023 08:48
@MunifTanjim MunifTanjim force-pushed the feat-postfix-default-cond branch 2 times, most recently from c709300 to d1f085f Compare May 26, 2023 08:56
@MunifTanjim MunifTanjim force-pushed the feat-postfix-default-cond branch 2 times, most recently from 8d87e56 to e16cbab Compare May 26, 2023 10:48
@L3MON4D3
Copy link
Owner

Could you also work in an option to disable our condition? Should be fine to pass it via context, no need for yet another opts-table xD

@L3MON4D3
Copy link
Owner

Aaaalrigth, this is done 👌
Thank you!!

@L3MON4D3 L3MON4D3 merged commit a83e4b1 into L3MON4D3:master May 26, 2023
@L3MON4D3 L3MON4D3 mentioned this pull request Apr 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L3MON4D3 L3MON4D3 L3MON4D3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MunifTanjim @L3MON4D3