-
-
Notifications
You must be signed in to change notification settings - Fork 245
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix invalid load path breaks later good paths
Loader `paths` can be a list, invalid path within (e.g., the directory doesn't exist) will be omitted, and other valid items should be kept. There is a problem that valid paths AFTER a bad one are omitted, too. The cause is after normalize paths, invalid item become nil hole, then `ipairs` in deduplicate function unexpectedly stopped there. Solution: remove nil before dedup. Small note: lua and snipmate loaders share `loader.util.get_load_paths_snipmate_like` helper thus fixed together. However vscode loader has its own `package.json` parsing logic so can't be treated the same.
- Loading branch information
Showing
4 changed files
with
31 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters