Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version up v4.2.8 #1398

Merged
merged 21 commits into from
Mar 17, 2024
Merged

Version up v4.2.8 #1398

merged 21 commits into from
Mar 17, 2024

Conversation

claustra01
Copy link
Member

No description provided.

ClearlyClaire and others added 21 commits February 14, 2024 11:02
* Ensure destruction of OAuth Applications notifies streaming

Due to doorkeeper using a dependent: delete_all relationship, the destroy of an OAuth Application bypassed the existing AccessTokenExtension callbacks for announcing destructing of access tokens.

* Ensure password resets revoke access to Streaming API

* Improve performance of deleting OAuth tokens

---------

Co-authored-by: Emelia Smith <[email protected]>
* Prevent different identities from a same SSO provider from accessing a same account

* Lock auth provider changes behind `ALLOW_UNSAFE_AUTH_PROVIDER_REATTACH=true`

* Rename methods to avoid confusion between OAuth and OmniAuth
* Fix insufficient Content-Type checking of fetched ActivityStreams objects

* Allow JSON-LD documents with multiple profiles
@claustra01 claustra01 merged commit bc3c942 into main Mar 17, 2024
18 of 23 checks passed
@claustra01 claustra01 deleted the version-up-v4.2.8 branch March 17, 2024 16:25
@claustra01 claustra01 restored the version-up-v4.2.8 branch March 17, 2024 16:25
return false unless response.mime_type == 'application/ld+json'

response.headers[HTTP::Headers::CONTENT_TYPE]&.split(';')&.map(&:strip)&.any? do |str|
str.start_with?('profile="') && str[9...-1].split.include?('https://www.w3.org/ns/activitystreams')

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

'
https://www.w3.org/ns/activitystreams
' can be anywhere in the URL, and arbitrary hosts may come before or after it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants