Merge branch 'main' into verup-to-4.2.9 #134
claustra01Annotations
10 errors and 2 warnings
|
lint:
app/controllers/settings/request_custom_emojis_controller.rb#L50
[Correctable] Layout/IndentationWidth: Use 2 (not 0) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
|
|
lint:
app/controllers/settings/request_custom_emojis_controller.rb#L69
[Correctable] Style/RedundantReturn: Redundant return detected. (https://rubystyle.guide#no-explicit-return)
|
|
lint:
app/models/form/request_custom_emoji_batch.rb#L30
[Correctable] Style/CombinableLoops: Combine this loop with the previous loop.
|
|
lint:
app/models/form/request_custom_emoji_batch.rb#L31
[Correctable] Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://rubystyle.guide#if-as-a-modifier)
|
|
lint:
app/models/form/request_custom_emoji_batch.rb#L33
[Correctable] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
|
|
lint:
app/models/form/request_custom_emoji_batch.rb#L46
[Correctable] Style/CombinableLoops: Combine this loop with the previous loop.
|
|
lint:
app/models/form/request_custom_emoji_batch.rb#L47
[Correctable] Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://rubystyle.guide#if-as-a-modifier)
|
|
lint:
app/models/form/request_custom_emoji_batch.rb#L47
[Correctable] Style/NumericPredicate: Use request_custom_emoji.state.zero? instead of request_custom_emoji.state == 0. (https://rubystyle.guide#predicate-methods)
|
|
lint:
app/models/form/request_custom_emoji_batch.rb#L56
[Correctable] Style/CombinableLoops: Combine this loop with the previous loop.
|
|
lint:
app/models/form/request_custom_emoji_batch.rb#L56
[Correctable] Style/SymbolProc: Pass &:destroy as an argument to each instead of a block.
|
|
lint:
app/mailers/application_mailer.rb#L24
Lint/DuplicateMethods: Method ApplicationMailer#set_autoreply_headers! is defined at both app/mailers/application_mailer.rb:18 and app/mailers/application_mailer.rb:24.
|
|
lint:
app/models/request_custom_emoji.rb#L53
[Correctable] Lint/UselessAccessModifier: Useless private access modifier.
|