Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate jetbrains annotations to jspecify #984

Open
wants to merge 1 commit into
base: main/4
Choose a base branch
from
Open

chore: migrate jetbrains annotations to jspecify #984

wants to merge 1 commit into from

Conversation

powercasgamer
Copy link
Contributor

@powercasgamer powercasgamer commented Oct 10, 2023 •
edited
Loading

closes #982

  • api
  • nbt
  • key
  • configurate3
  • configurate4
  • text-logger-slf4j
  • text-minimessage
  • text-serializer-ansi
  • text-serializer-gson
  • text-serializer-gson-legacy-impl
  • text-serializer-json
  • text-serializer-json-legacy-impl
  • text-serializer-legacy
  • text-serializer-plain

@kezz
Copy link
Member

kezz commented Oct 10, 2023

This should be using package/class level @NullMarked annotations

@powercasgamer powercasgamer marked this pull request as ready for review October 13, 2023 18:26
@powercasgamer powercasgamer requested a review from kashike October 16, 2023 09:01
@powercasgamer powercasgamer force-pushed the chore/migrate-to-jspecify branch from 430f65e to 61890a0 Compare October 19, 2023 20:26
@powercasgamer powercasgamer force-pushed the chore/migrate-to-jspecify branch from 61890a0 to f39059c Compare October 19, 2023 20:28
@zml2008 zml2008 added this to the 5.0.0 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashike kashike Awaiting requested review from kashike

Assignees
No one assigned
Labels
area: api area: key area: nbt area: serialiser/configurate3 area: serialiser/configurate4 area: text-logger-slf4j area: text-minimessage area: text-serialiser/ansi area: text-serialiser/gson area: text-serialiser/legacy area: text-serialiser/plain-text type: enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Migrate to JSpecify
4 participants
@powercasgamer @kezz @kashike @zml2008