-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename static constructors #923
Merged
zml2008
merged 8 commits into
KyoriPowered:main/4
from
powercasgamer:chore/rename-static
May 12, 2023
Merged
chore: rename static constructors #923
zml2008
merged 8 commits into
KyoriPowered:main/4
from
powercasgamer:chore/rename-static
May 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powercasgamer
changed the title
chore: rename static in HoverEvent.ShowItem
chore: rename static constructors
May 11, 2023
powercasgamer
force-pushed
the
chore/rename-static
branch
from
May 11, 2023 21:04
f231bd2
to
4fa2e0a
Compare
kashike
approved these changes
May 11, 2023
zml2008
approved these changes
May 12, 2023
zml2008
requested changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> Task :adventure-text-serializer-gson:compileTestJava
/home/runner/work/adventure/adventure/text-serializer-gson/src/test/java/net/kyori/adventure/text/serializer/gson/TranslatableComponentTest.java:69: warning: [deprecation] of(Key,UUID,Component) in ShowEntity has been deprecated
.hoverEvent(HoverEvent.showEntity(HoverEvent.ShowEntity.of(
one last deprecation from Actions
fixed |
zml2008
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #454