feat: add pattern annotations #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezz
requested changes
May 10, 2023
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/internal/TagInternals.java
Outdated
Show resolved
Hide resolved
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/internal/TagInternals.java
Outdated
Show resolved
Hide resolved
powercasgamer
commented
May 10, 2023
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/internal/TagPattern.java
Outdated
Show resolved
Hide resolved
powercasgamer
force-pushed
the
feat/pattern-annotation
branch
from
bdd7da8 to
3913bb5
Compare
kashike
requested changes
May 10, 2023
Comment on lines
+43
to
+46
| @Documented | ||
| @Retention(RetentionPolicy.CLASS) | ||
| @Target({ METHOD, FIELD, PARAMETER, LOCAL_VARIABLE }) | ||
| public @Pattern(TagInternals.TAG_NAME_REGEX) @interface TagPattern { |
There was a problem hiding this comment.
Suggested change
| @Documented | |
| @Retention(RetentionPolicy.CLASS) | |
| @Target({ METHOD, FIELD, PARAMETER, LOCAL_VARIABLE }) | |
| public @Pattern(TagInternals.TAG_NAME_REGEX) @interface TagPattern { | |
| @Documented | |
| @Pattern(TagInternals.TAG_NAME_REGEX) | |
| @Retention(RetentionPolicy.CLASS) | |
| @Target({ METHOD, FIELD, PARAMETER, LOCAL_VARIABLE }) | |
| public @interface TagPattern { |
There was a problem hiding this comment.
If I do this it won't compile due to checkstyle. discord message
kashike
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #752