ANSIComponentSerializer #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymiel
force-pushed
the
feat/ansi-component-serializer
branch
2 times, most recently
from
b4f56a3 to
8d7c3f6
Compare
zml2008
requested changes
Apr 10, 2023
...zer-ansi/src/main/java/net/kyori/adventure/text/serializer/ansi/ANSIComponentSerializer.java
Outdated
Show resolved
Hide resolved
...zer-ansi/src/main/java/net/kyori/adventure/text/serializer/ansi/ANSIComponentSerializer.java
Outdated
Show resolved
Hide resolved
...zer-ansi/src/main/java/net/kyori/adventure/text/serializer/ansi/ANSIComponentSerializer.java
Outdated
Show resolved
Hide resolved
zml2008
requested changes
Apr 11, 2023
...zer-ansi/src/main/java/net/kyori/adventure/text/serializer/ansi/ANSIComponentSerializer.java
Outdated
Show resolved
Hide resolved
...zer-ansi/src/main/java/net/kyori/adventure/text/serializer/ansi/ANSIComponentSerializer.java
Outdated
Show resolved
Hide resolved
...ansi/src/main/java/net/kyori/adventure/text/serializer/ansi/ANSIComponentSerializerImpl.java
Outdated
Show resolved
Hide resolved
...ansi/src/main/java/net/kyori/adventure/text/serializer/ansi/ANSIComponentSerializerImpl.java
Outdated
Show resolved
Hide resolved
...zer-ansi/src/main/java/net/kyori/adventure/text/serializer/ansi/ANSIComponentSerializer.java
Outdated
Show resolved
Hide resolved
rymiel
added a commit
that referenced
this pull request
Apr 11, 2023
ComponentEncoder is akin to ComponentSerializer, except it doesn't provide deserialization. This is intended to be used in #898. ComponentSerializer now extends ComponentEncoder, but still overrides the methods with exact copies, to keep the javadocs more clear. These originals also retain their old `@since` tags.
Merged
rymiel
added a commit
that referenced
this pull request
Apr 11, 2023
ComponentEncoder is akin to ComponentSerializer, except it doesn't provide deserialization. This is intended to be used in #898. ComponentSerializer now extends ComponentEncoder, but still overrides the methods with exact copies, to keep the javadocs more clear. These originals also retain their old `@since` tags.
rymiel
force-pushed
the
feat/ansi-component-serializer
branch
from
268ecd3 to
3f20aaa
Compare
Basically so far it's just a thing which pipes together an ANSIComponentRenderer from net.kyori.ansi and a ComponentFlattener. NEEDS MORE TESTS AAAA
Co-authored-by: zml <[email protected]>
zml2008
approved these changes
Apr 24, 2023
zml2008
requested changes
Apr 25, 2023
...zer-ansi/src/main/java/net/kyori/adventure/text/serializer/ansi/ANSIComponentSerializer.java
Outdated
Show resolved
Hide resolved
zml2008
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #140
Fixes KyoriPowered/ansi#7
Fixes #125