ComponentFlattenerImpl: translatable components check fallback first #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zml2008
approved these changes
Apr 8, 2023
kezz
approved these changes
Apr 8, 2023
rainbowdashlabs
referenced
this pull request
in eldoriarpg/survivalschematicbrush
Apr 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [net.kyori:adventure-text-minimessage](https://togithub.com/KyoriPowered/adventure) | `4.13.0` -> `4.13.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>KyoriPowered/adventure</summary> ### [`v4.13.1`](https://togithub.com/KyoriPowered/adventure/releases/tag/v4.13.1): 🌏 Adventure 4.13.1 Adventure 4.13.1 is a bugfix release with fixes focused around MiniMessage and translatable component fallbacks. We recommend updating at your earliest convenience. #### Fixes 🐛 - fix some issues with translatable component fallback by [@​LemonCaramel](https://togithub.com/LemonCaramel) in [https://github.com/KyoriPowered/adventure/pull/885](https://togithub.com/KyoriPowered/adventure/pull/885) - ComponentFlattenerImpl: translatable components check fallback first by [@​Camotoy](https://togithub.com/Camotoy) in [https://github.com/KyoriPowered/adventure/pull/895](https://togithub.com/KyoriPowered/adventure/pull/895) - fix(text-minimessage): Correctly handle phase and multi-colour gradients by [@​zml2008](https://togithub.com/zml2008) in [https://github.com/KyoriPowered/adventure/pull/896](https://togithub.com/KyoriPowered/adventure/pull/896) #### New Contributors - [@​LemonCaramel](https://togithub.com/LemonCaramel) made their first contribution in [https://github.com/KyoriPowered/adventure/pull/885](https://togithub.com/KyoriPowered/adventure/pull/885) - [@​Camotoy](https://togithub.com/Camotoy) made their first contribution in [https://github.com/KyoriPowered/adventure/pull/895](https://togithub.com/KyoriPowered/adventure/pull/895) **Full Changelog**: KyoriPowered/adventure@v4.13.0...v4.13.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/eldoriarpg/survivalschematicbrush). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @kashike for this suggestion. If an implementation's TranslatableComponentRenderer returns null if no translation string is found, then this change fixes #888.