Improve compaction of empty/blank TextComponents #764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve compaction of empty/blank TextComponents
I believe that for a TextComponent comprised of only space characters (" "), TextColor and ITALIC stylings are redundant.
We can take advantage of this in order to further compact components.
Font and BOLD stylings also seem like candidates for removal, but afaik BOLD affects the advance of space character and in 1.19 Font will do so too.
Some examples
Removal of useless styling on blank components
Input:
{"text":" ","color":"red"}
Before:
{"text":" ","color":"red"}
After:
{"text":" "}
Compaction of blank components (side effect of previous)
Input:
{"text":"Hello ","extra":[{"color":"red","text":" "}]}
Before:
{"text":"Hello ","extra":[{"color":"red","text":" "}]}
After:
{"text":"Hello "}
#Removal of empty children, regardless of style
Input:
{"text":"Hello ","color":"red","extra":[{"strikethrough":true,"text":""}]}
Before:
{"text":"Hello ","color":"red","extra":[{"strikethrough":true,"text":""}]}
After:
{"text":"Hello ","color":"red"}