Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text-logger-slf4j: introduce wrapper for formatted logging #757

Merged
merged 9 commits into from
Jun 2, 2022
Merged

text-logger-slf4j: introduce wrapper for formatted logging #757

merged 9 commits into from
Jun 2, 2022

Conversation

zml2008
Copy link
Member

@zml2008 zml2008 commented Apr 26, 2022 •
edited
Loading

Fixes GH-731

TODOs:

  • make sure location information is passed through to logger implementations properly -- we might have to call LocationAwareLogger directly?
  • is our handling of argument arrays correct
  • test implemenations -- we should have prototypes for paper and fabric
  • does SLF4J have a test harness? or can we mockito up something?
  • is it worth doing something with ComponentMessageThrowables as special handling for the throwable param?
  • Override all String logging methods to process component arguments/throwables passed

@zml2008 zml2008 added this to the 4.11.0 milestone Apr 26, 2022
This was referenced Apr 26, 2022
Closed
Open
@4drian3d 4drian3d mentioned this pull request Apr 27, 2022
Closed
@zml2008 zml2008 marked this pull request as ready for review May 22, 2022 02:04
@zml2008 zml2008 force-pushed the feature/slf4j-logger branch 2 times, most recently from 669e060 to 5314940 Compare May 22, 2022 02:24
@zml2008 zml2008 mentioned this pull request May 22, 2022
Merged
kezz
kezz requested changes May 25, 2022
View reviewed changes
Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very very minor comments here - overall this is some super dope stuff and it's really cool :)

bom/build.gradle.kts Show resolved Hide resolved
...ogger-slf4j/src/main/java/net/kyori/adventure/text/logger/slf4j/ComponentLoggerProvider.java Show resolved Hide resolved
...ogger-slf4j/src/main/java/net/kyori/adventure/text/logger/slf4j/ComponentLoggerProvider.java Show resolved Hide resolved
...ogger-slf4j/src/main/java/net/kyori/adventure/text/logger/slf4j/ComponentLoggerProvider.java Show resolved Hide resolved
...ogger-slf4j/src/main/java/net/kyori/adventure/text/logger/slf4j/ComponentLoggerProvider.java Show resolved Hide resolved
text-logger-slf4j/src/main/java/net/kyori/adventure/text/logger/slf4j/Handler.java Show resolved Hide resolved
text-logger-slf4j/src/main/java/net/kyori/adventure/text/logger/slf4j/Handler.java Show resolved Hide resolved
@zml2008 zml2008 force-pushed the feature/slf4j-logger branch from e632b6c to 916a596 Compare June 1, 2022 03:38
@zml2008 zml2008 self-assigned this Jun 2, 2022
@zml2008 zml2008 merged commit 5c2d340 into main/4 Jun 2, 2022
@zml2008 zml2008 deleted the feature/slf4j-logger branch June 2, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezz kezz kezz approved these changes

Assignees

@zml2008 zml2008

Labels
area: text-logger-slf4j type: enhancement
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

Add SLF4J wrapper for logging components
2 participants
@zml2008 @kezz