Implement MiniMessage preprocessor and cleanup parsing #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows the parser to infer message content from the ContextImpl that was passed to it, instead of relying on a redundant rich message parameter.
implements a preprocessor for minimessages: behaves exactly like a postprocessor like in existing versions, except the unary operator acts on the raw input strings prior to parsing
fixes StackOverflowError from escaping, introduced by 8671d4b
adds a unit test that checks if basic preprocessing is functional
fixes some issues with a lack of newlines, final keywords, and this-dots
kezz
requested changes
Apr 9, 2022
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/MiniMessage.java
Outdated
Show resolved
Hide resolved
replace "end" with "start" in preprocessor javadoc
whoopsies, i guess that's what i get for copy & paste :D |
kashike
requested changes
Apr 9, 2022
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/ContextImpl.java
Outdated
Show resolved
Hide resolved
moves the ContextImpl constructor's closing bracket to a new line Co-authored-by: Riley Park <[email protected]>
|
oh whoops sorry kezz didnt mean to press buttons |
|
Out of curiosity, what was your planned usecase for this pre-processing function? |
I believe the initial use-case for this was a preprocessor that word wraps the input prior to building the components — the discussion that led to this change is in the #adventure channel on the Kyori discord server |
zml2008
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request combines two changes to MiniMessage, one internal and the other external.
On the user-facing side, a new feature is implemented: preprocessing. This is essentially exactly opposite to the existing post-processing in MiniMessage: it's simply a unary operator that is applied to every string input prior to deserialising it into a tree.
On the internal side, this also removes the explicit
richMessageparameters from most MiniMessageParser methods, opting to instead deduce the value from ContextImpl where possible. A notable outlier here is the process of escaping tokens, where therichMessageparameter is explicitly required for escaping to work.