-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text-minimessage: Use a Consumer rather than Appendable for debug output #671
Conversation
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/MiniMessageParser.java
Show resolved
Hide resolved
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/MiniMessage.java
Show resolved
Hide resolved
May i ask, why do you use null if debug is disabled? Why not just empty consumer? |
Also, consider adding convenience method to builder that accepts Appendable and sneaky throws IOException? |
There are some non-zero cost calculations/string formatting that takes place that doesn't need to happen if nobody is caring about the logging.
I'm not massively interested in adding a convenience method for |
Fixes GH-667