CSS Colors Tag Resolver #664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/minimessage/css-colors
MiniDigger
reviewed
Jan 13, 2022
...java/net/kyori/adventure/text/minimessage/transformation/inbuild/CSSColorTransformation.java
Outdated
Show resolved
Hide resolved
MiniDigger
reviewed
Jan 13, 2022
...ge/src/main/java/net/kyori/adventure/text/minimessage/transformation/TransformationType.java
Outdated
Show resolved
Hide resolved
|
Blocking on #672, will need to be rewritten to use the new tag system after merge. |
Fetch upstream
…into feature/minimessage/css-colors
|
Added the new CSSColorTagResolver in a new package I called "nonstandard". Happy to change that package name or move it somewhere else but I saw mention of the possibility of tags being added that wouldn't be "standard" so I stuck it there. |
zml2008
requested changes
Feb 22, 2022
.../src/main/java/net/kyori/adventure/text/minimessage/tag/nonstandard/CSSColorTagResolver.java
Outdated
Show resolved
Hide resolved
.../src/main/java/net/kyori/adventure/text/minimessage/tag/nonstandard/CSSColorTagResolver.java
Outdated
Show resolved
Hide resolved
.../src/main/java/net/kyori/adventure/text/minimessage/tag/nonstandard/CSSColorTagResolver.java
Outdated
Show resolved
Hide resolved
|
This tag will also want a companion pr to https://github.com/KyoriPowered/adventure-docs. |
|
The map of css colors should probably move. I'm just not sure where to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #516, this PR adds a new non-standard tag,
CSSColorTagResolver, that allows for all standard CSS colors to be parsed with MiniMessage. If bothCSSColorTagResolverandColorTagResolverare included and a color is specified that is included in both (ex. aqua), then the standard named text color is used. You can specify to use the CSS color like so:<css:aqua>.