Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Add possibility of using Component#join with a root style #653

Merged
merged 3 commits into from
Apr 26, 2022
Merged

feat(api): Add possibility of using Component#join with a root style #653

merged 3 commits into from
Apr 26, 2022

Conversation

KingOfSquares
Copy link
Contributor

Closes #505

@KingOfSquares KingOfSquares requested a review from kezz December 22, 2021 19:06
kezz
kezz requested changes Jan 2, 2022
View reviewed changes
Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of docs nitpicks here and a minor change for the single element join method. This is a very good change though!

api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfigurationImpl.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfigurationImpl.java Show resolved Hide resolved
kezz
kezz requested changes Feb 13, 2022
View reviewed changes
Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style needs to be added to the toString output

kezz
kezz approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs since tags updating, but otherwise LGTM!

@kezz kezz added this to the 4.11.0 milestone Apr 20, 2022
@zml2008 zml2008 force-pushed the join-with-rootstyle branch from 75fcd6b to 567a278 Compare April 26, 2022 00:10
@zml2008 zml2008 self-assigned this Apr 26, 2022
@zml2008 zml2008 merged commit 57d5319 into KyoriPowered:main/4 Apr 26, 2022
@KingOfSquares KingOfSquares deleted the join-with-rootstyle branch May 11, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezz kezz kezz approved these changes

@zml2008 zml2008 zml2008 approved these changes

Assignees

@zml2008 zml2008

Labels
area: api type: enhancement
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

Add a parent component/style to JoinConfiguration
3 participants
@KingOfSquares @zml2008 @kezz