-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix premature SNBT parsing as number #497
Merged
kashike
merged 3 commits into
KyoriPowered:master
from
kennytv:fix/premature-numeric-parsing
Nov 4, 2021
Merged
Fix premature SNBT parsing as number #497
kashike
merged 3 commits into
KyoriPowered:master
from
kennytv:fix/premature-numeric-parsing
Nov 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
approved these changes
Nov 4, 2021
This was referenced Feb 28, 2022
Merged
Merged
Merged
This was referenced Feb 28, 2022
Merged
Merged
Merged
This was referenced Mar 14, 2022
This was referenced Apr 13, 2022
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┬┴┬┴┤(・_├┬┴┬┴
If a numeric token is found before an unquoted string's end, it will be prematurely parsed as a number and errors because of remaining/unread characters for strings such as
0dd
,11fa
, or1350diamonds_plz
.Instead of constantly looking for the numeric tokens, this just reads the full string and if all chars meet the required criterea (previously
possiblyNumeric
) except for the very last character, the token parser will be called. If it's possibly numeric all the way through, it goes to the int parser, otherwise to the same code below.