-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix titles on 1.8 #477
Fix titles on 1.8 #477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like for this to be tested on 1.17 at least, but it's a small fix and as far as I could tell when I implemented this, 1.17 doesn't care about the order they are received in.
I'll test it on spigot 1.17 |
Everything seems to be working. |
Please also merge my PR on adventure-platform since that is also required to fix titles on 1.8: KyoriPowered/adventure-platform#64 |
Due to how 1.8 works, it's required to send times and subtitle packets before the main title packet.
I didn't test if this doesn't break newer versions, but I don't see a reason why it could.
I made the same fix for adventure-platform too: KyoriPowered/adventure-platform#64