Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix titles on 1.8 #477

Merged
merged 2 commits into from
Oct 16, 2021
Merged

Fix titles on 1.8 #477

merged 2 commits into from
Oct 16, 2021

Conversation

vytskalt
Copy link
Contributor

@vytskalt vytskalt commented Oct 15, 2021

Due to how 1.8 works, it's required to send times and subtitle packets before the main title packet.
I didn't test if this doesn't break newer versions, but I don't see a reason why it could.

I made the same fix for adventure-platform too: KyoriPowered/adventure-platform#64

Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like for this to be tested on 1.17 at least, but it's a small fix and as far as I could tell when I implemented this, 1.17 doesn't care about the order they are received in.

@vytskalt
Copy link
Contributor Author

I'd like for this to be tested on 1.17 at least, but it's a small fix and as far as I could tell when I implemented this, 1.17 doesn't care about the order they are received in.

I'll test it on spigot 1.17

@vytskalt
Copy link
Contributor Author

Everything seems to be working.

@kashike kashike added this to the 4.10.0 milestone Oct 15, 2021
@zml2008 zml2008 merged commit eea1a16 into KyoriPowered:master Oct 16, 2021
@zml2008 zml2008 self-assigned this Oct 16, 2021
@vytskalt
Copy link
Contributor Author

Please also merge my PR on adventure-platform since that is also required to fix titles on 1.8: KyoriPowered/adventure-platform#64

zml2008 pushed a commit that referenced this pull request Oct 31, 2021
send times packet first
yes
This was referenced Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants