-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Pointers supplier #429
Conversation
api/src/main/java/net/kyori/adventure/pointer/PointersSupplier.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/pointer/PointersSupplier.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/pointer/PointersSupplierImpl.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/pointer/PointersSupplierImpl.java
Outdated
Show resolved
Hide resolved
Looks good -- probably more useful for native implementations than One thing i'd like to see is some sort of 'inheritance' functionality. |
Do you think it would make more sense for the builder to have a |
api/src/main/java/net/kyori/adventure/pointer/PointersSupplier.java
Outdated
Show resolved
Hide resolved
@kezz I think that would be a reasonable option |
5a6bd4c
to
cb49c69
Compare
cb49c69
to
2788047
Compare
2788047
to
9cfffd4
Compare
Rebased and addressed zml's comments. You can now pass a parent to the supplier builder - see the PR description for an updated example. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [net.kyori:adventure-text-serializer-legacy](https://togithub.com/KyoriPowered/adventure) | `4.16.0` -> `4.17.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/net.kyori:adventure-text-serializer-legacy/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/net.kyori:adventure-text-serializer-legacy/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/net.kyori:adventure-text-serializer-legacy/4.16.0/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/net.kyori:adventure-text-serializer-legacy/4.16.0/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [net.kyori:adventure-text-serializer-gson](https://togithub.com/KyoriPowered/adventure) | `4.16.0` -> `4.17.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/net.kyori:adventure-text-serializer-gson/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/net.kyori:adventure-text-serializer-gson/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/net.kyori:adventure-text-serializer-gson/4.16.0/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/net.kyori:adventure-text-serializer-gson/4.16.0/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [net.kyori:adventure-api](https://togithub.com/KyoriPowered/adventure) | `4.16.0` -> `4.17.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/net.kyori:adventure-api/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/net.kyori:adventure-api/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/net.kyori:adventure-api/4.16.0/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/net.kyori:adventure-api/4.16.0/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>KyoriPowered/adventure (net.kyori:adventure-text-serializer-legacy)</summary> ### [`v4.17.0`](https://togithub.com/KyoriPowered/adventure/releases/tag/v4.17.0): 🌏 Adventure 4.17.0 <!-- Release notes generated using configuration in .github/release.yaml at main/4 --> #### What's Changed ##### ✨ Features - feat(text-minimessage): Show ANSI rendering of parsed components in tests by [@​zml2008](https://togithub.com/zml2008) in [https://github.com/KyoriPowered/adventure/pull/1042](https://togithub.com/KyoriPowered/adventure/pull/1042) - feat(minimessage): Add target to deserialization for contextual tags by [@​kezz](https://togithub.com/kezz) in [https://github.com/KyoriPowered/adventure/pull/1051](https://togithub.com/KyoriPowered/adventure/pull/1051) - feat(api): Pointers supplier by [@​kezz](https://togithub.com/kezz) in [https://github.com/KyoriPowered/adventure/pull/429](https://togithub.com/KyoriPowered/adventure/pull/429) - 1.20.5 by [@​zml2008](https://togithub.com/zml2008) in [https://github.com/KyoriPowered/adventure/pull/1055](https://togithub.com/KyoriPowered/adventure/pull/1055) ##### 🐛 Fixes - fix(text-minimessage): Handle larger raninbow phases correctly by [@​zml2008](https://togithub.com/zml2008) in [https://github.com/KyoriPowered/adventure/pull/1041](https://togithub.com/KyoriPowered/adventure/pull/1041) - fix: Allow for case-insensitivity in legacy serializer, closes [#​1043](https://togithub.com/KyoriPowered/adventure/issues/1043) by [@​kezz](https://togithub.com/kezz) in [https://github.com/KyoriPowered/adventure/pull/1044](https://togithub.com/KyoriPowered/adventure/pull/1044) - fix(api): Only trigger bossbar listeners if flags actually changed by [@​zml2008](https://togithub.com/zml2008) in [https://github.com/KyoriPowered/adventure/pull/1067](https://togithub.com/KyoriPowered/adventure/pull/1067) - fix(nbt): `CompoundBinaryTag#getBoolean` ignores false values when default value is true by [@​kashike](https://togithub.com/kashike) in KyoriPowered/adventure@e0edf0f - fix(nbt): `ListBinaryTag` is weakly immutable by [@​kashike](https://togithub.com/kashike) in KyoriPowered/adventure@2e612aa **Full Changelog**: KyoriPowered/adventure@v4.16.0...v4.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6:00am" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/CloudNetService/CloudNet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibmlnaHRseSIsImxhYmVscyI6WyJ0OiBkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR closes #428 by providing the
PointersSupplier
class which can be stored statically and resolved wheneverAudience#pointers()
is called to prevent having a bazillion hash maps lying about that all do the same thing.When implemented, it would look something like this: