-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove checker qual and migrate to jetbrains annotations #390
Conversation
|
I pondered that but it's not really true, we do know the nullability but there's no way to accurately express it. That being said, it is definitely the case that |
I would rather we drop the annotation - I know that having this |
Okie dokie! I've moved it over to |
api/src/main/java/net/kyori/adventure/audience/EmptyAudience.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/audience/ForwardingAudience.java
Outdated
Show resolved
Hide resolved
Rebase required. |
Closes #386.
This also removes the compile only dependencies on checker qual, not sure if these should be left until a breaking release or not.
Some points of note:
@Nullable
annotations were added where they were missing in equals overrides.@MonotonicNonNull
or@PolyNull
. Both have been replaced with@Nullable
annotations with appropriate@Contract
annotations for poly null methods.