-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Audience#foreach
and Audience#filter
#365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a decent idea - there's a lot of good use cases for it at least. However, I wonder if it might just be worth implementing Iterable
at this point?
I mentioned this in Discord and it got lost to time so I'll just repeat here. It could be a good idea to just provide a method to get the audience as an iterable directly. Maybe exposing a stream as well could be a more "standard" way of implementing the filter system. |
a4d5796
to
20e1612
Compare
api/src/main/java/net/kyori/adventure/audience/ForwardingAudience.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/audience/ForwardingAudience.java
Outdated
Show resolved
Hide resolved
20e1612
to
4d126e6
Compare
To be honest, I don't see the usecase...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs updating in regards to @since
tags and style changes, but I like the concept - especially so with the addition of pointers.
api/src/main/java/net/kyori/adventure/audience/ForwardingAudience.java
Outdated
Show resolved
Hide resolved
4d126e6
to
c693aff
Compare
c693aff
to
8532327
Compare
No description provided.