Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally emit type field for JSON serializers #1123

Open
wants to merge 1 commit into
base: main/4
Choose a base branch
from

Conversation

kezz
Copy link
Member

@kezz kezz commented Oct 30, 2024

Closes #1121

@zml2008
Copy link
Member

zml2008 commented Dec 8, 2024

I get the goal of emitting the type field to have some initial support, but it feels kinda icky to have the types be just part of the gson serializer's giant if tree, and not even enforced when parsing. Is this level of support super essential for you or would you be fine pushing this to a later release to develop further? Cuz like the whole structural/keyed typing hybrid already lol

@zml2008 zml2008 modified the milestones: 4.18.0, 4.19.0 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally emit type field in JSON serializers
2 participants