revise: MiniMessageTranslator #972 #1089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powercasgamer
suggested changes
Jul 2, 2024
His activities have been gone for three months, and I'm not the author or co author, I think the feature is good but it hasn't been changed in a long time |
|
There should be a reason why he didn't finish or why he didn't mark the pr as ready, and the author is active, just not on that pr. Be patient |
|
The original PR is waiting on virtual components for named arguments (i.e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the original PR #972 . The original PR was not merged due to several review comments, and the original author is no longer making updates. To continue the development and integration of this feature, I have revised and improved the initial submission.