-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(text-minimessage): Handle larger raninbow phases correctly #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezz
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I do think it would be nice to be able to configure the division part but honestly we should probably wait for some sort of resolution to #1038 before we start adding more complexity to the rainbow tag.
0utplay
referenced
this pull request
in CloudNetService/CloudNet
May 16, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [net.kyori:adventure-text-serializer-legacy](https://togithub.com/KyoriPowered/adventure) | `4.16.0` -> `4.17.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/net.kyori:adventure-text-serializer-legacy/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/net.kyori:adventure-text-serializer-legacy/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/net.kyori:adventure-text-serializer-legacy/4.16.0/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/net.kyori:adventure-text-serializer-legacy/4.16.0/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [net.kyori:adventure-text-serializer-gson](https://togithub.com/KyoriPowered/adventure) | `4.16.0` -> `4.17.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/net.kyori:adventure-text-serializer-gson/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/net.kyori:adventure-text-serializer-gson/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/net.kyori:adventure-text-serializer-gson/4.16.0/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/net.kyori:adventure-text-serializer-gson/4.16.0/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [net.kyori:adventure-api](https://togithub.com/KyoriPowered/adventure) | `4.16.0` -> `4.17.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/net.kyori:adventure-api/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/net.kyori:adventure-api/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/net.kyori:adventure-api/4.16.0/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/net.kyori:adventure-api/4.16.0/4.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>KyoriPowered/adventure (net.kyori:adventure-text-serializer-legacy)</summary> ### [`v4.17.0`](https://togithub.com/KyoriPowered/adventure/releases/tag/v4.17.0): 🌏 Adventure 4.17.0 <!-- Release notes generated using configuration in .github/release.yaml at main/4 --> #### What's Changed ##### ✨ Features - feat(text-minimessage): Show ANSI rendering of parsed components in tests by [@​zml2008](https://togithub.com/zml2008) in [https://github.com/KyoriPowered/adventure/pull/1042](https://togithub.com/KyoriPowered/adventure/pull/1042) - feat(minimessage): Add target to deserialization for contextual tags by [@​kezz](https://togithub.com/kezz) in [https://github.com/KyoriPowered/adventure/pull/1051](https://togithub.com/KyoriPowered/adventure/pull/1051) - feat(api): Pointers supplier by [@​kezz](https://togithub.com/kezz) in [https://github.com/KyoriPowered/adventure/pull/429](https://togithub.com/KyoriPowered/adventure/pull/429) - 1.20.5 by [@​zml2008](https://togithub.com/zml2008) in [https://github.com/KyoriPowered/adventure/pull/1055](https://togithub.com/KyoriPowered/adventure/pull/1055) ##### 🐛 Fixes - fix(text-minimessage): Handle larger raninbow phases correctly by [@​zml2008](https://togithub.com/zml2008) in [https://github.com/KyoriPowered/adventure/pull/1041](https://togithub.com/KyoriPowered/adventure/pull/1041) - fix: Allow for case-insensitivity in legacy serializer, closes [#​1043](https://togithub.com/KyoriPowered/adventure/issues/1043) by [@​kezz](https://togithub.com/kezz) in [https://github.com/KyoriPowered/adventure/pull/1044](https://togithub.com/KyoriPowered/adventure/pull/1044) - fix(api): Only trigger bossbar listeners if flags actually changed by [@​zml2008](https://togithub.com/zml2008) in [https://github.com/KyoriPowered/adventure/pull/1067](https://togithub.com/KyoriPowered/adventure/pull/1067) - fix(nbt): `CompoundBinaryTag#getBoolean` ignores false values when default value is true by [@​kashike](https://togithub.com/kashike) in KyoriPowered/adventure@e0edf0f - fix(nbt): `ListBinaryTag` is weakly immutable by [@​kashike](https://togithub.com/kashike) in KyoriPowered/adventure@2e612aa **Full Changelog**: KyoriPowered/adventure@v4.16.0...v4.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6:00am" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/CloudNetService/CloudNet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibmlnaHRseSIsImxhYmVscyI6WyJ0OiBkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-1040