feat(api): Expand the supported resource pack operations for 1.20.3 #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
requested changes
Dec 10, 2023
api/src/main/java/net/kyori/adventure/resource/ResourcePackRequest.java
Outdated
Show resolved
Hide resolved
|
hm, looking at adding Iterable overloads, type erasure means we can't support all the individual types for each method. Right now, i feel like the best signature for implementations would be |
|
Looking at Vanilla again, it appears that while the client will accept multiple packs, it only uses the last |
Machine-Maker
previously requested changes
Dec 12, 2023
api/src/main/java/net/kyori/adventure/resource/ResourcePackInfo.java
Outdated
Show resolved
Hide resolved
kezz
reviewed
Dec 14, 2023
…packs The `required` and `prompt` fields are only taken from the last pack in the request in vanilla anyways, so they behave on what we call the request level.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it easy to handle multiple resource packs, and adds a callback system to track pack application.
(note, this does change some API used in snapshots so it'd be a binary break for any current testers)