Style decorations are lost after Modifying tags are applied

[metabrixkt]

Input

<gradient>This <italic>is</italic> a <bold>test</bold>!</gradient>

Expected output

JSON

{
    "extra": [
        {
            "color": "white",
            "text": "T"
        },
        {
            "color": "#eeeeee",
            "text": "h"
        },
        {
            "color": "#dddddd",
            "text": "i"
        },
        {
            "color": "#cccccc",
            "text": "s"
        },
        {
            "color": "#bbbbbb",
            "text": " "
        },
        {
            "italic": true,
            "extra": [
                {
                    "color": "gray",
                    "text": "i"
                },
                {
                    "color": "#999999",
                    "text": "s"
                }
            ],
            "text": ""
        },
        {
            "color": "#888888",
            "text": " "
        },
        {
            "color": "#777777",
            "text": "a"
        },
        {
            "color": "#666666",
            "text": " "
        },
        {
            "bold": true,
            "extra": [
                {
                    "color": "dark_gray",
                    "text": "t"
                },
                {
                    "color": "#444444",
                    "text": "e"
                },
                {
                    "color": "#333333",
                    "text": "s"
                },
                {
                    "color": "#222222",
                    "text": "t"
                }
            ],
            "text": ""
        },
        {
            "color": "#111111",
            "text": "!"
        }
    ],
    "text": ""
}

Actual (observed) output

JSON

{
    "extra": [
        {
            "color": "white",
            "text": "T"
        },
        {
            "color": "#eeeeee",
            "text": "h"
        },
        {
            "color": "#dddddd",
            "text": "i"
        },
        {
            "color": "#cccccc",
            "text": "s"
        },
        {
            "color": "#bbbbbb",
            "text": " "
        },
        {
            "color": "gray",
            "text": "i"
        },
        {
            "color": "#999999",
            "text": "s"
        },
        {
            "color": "#888888",
            "text": " "
        },
        {
            "color": "#777777",
            "text": "a"
        },
        {
            "color": "#666666",
            "text": " "
        },
        {
            "color": "dark_gray",
            "text": "t"
        },
        {
            "color": "#444444",
            "text": "e"
        },
        {
            "color": "#333333",
            "text": "s"
        },
        {
            "color": "#222222",
            "text": "t"
        },
        {
            "color": "#111111",
            "text": "!"
        }
    ],
    "text": ""
}

Other information

Version: 4.11.0 (also reproduced at 167e46d which is 4.12.0-SNAPSHOT)

I had some troubles reproducing this sometimes. First time when I found this bug, I was using this code:

Gson gson = new GsonBuilder().setPrettyPrinting().create();
Component component = Component.text("20");
System.out.println("component = " + gson.toJson(GsonComponentSerializer.gson().serializeToTree(component)));
Component customName = event.isCritical()
        ? MiniMessage.miniMessage().deserialize(
        "<gradient:#FFAA00:#FF5555><component></gradient>",
        Placeholder.component("component", component.append(Component.text("✧").decorate(TextDecoration.BOLD)))
) : component;
System.out.println("customName = " + gson.toJson(GsonComponentSerializer.gson().serializeToTree(customName)));

and got this output:

[14:14:39 INFO]: [STDOUT] component = {
  "extra": [
    {
      "bold": true,
      "text": "✧"
    }
  ],
  "text": "20"
}
[14:14:39 INFO]: [STDOUT] customName = {
  "extra": [
    {
      "color": "gold",
      "text": "2"
    },
    {
      "color": "#ff8e1c",
      "text": "0"
    },
    {
      "color": "#ff7139",
      "text": "✧"
    }
  ],
  "text": ""
}

I found that here at line 121 new Component is created with this.color() instead of textComponent.style().color(this.color()) as a second argument, thus styles are lost.

After some debugging I found that text components with is and test contents that are being sent to apply(Component, int) method, are actually {"italic": true, "text": "", "extra": [{"text": "is"}]} and {"bold": true, "text": "", "extra": [{"text": "test"}]} after inner italic and bold tags are applied. Inner {"text": "is"} and {"text": "test"} don't have styles at all, so nothing would be applied even with the fix I described in the previous paragraph.

[zml2008]

Thanks for your thorough investigation! Seems like this is an issue that comes up when you use component placeholders -- internally MM doesn't have multiple style elements on one tag, but I believe your fix should work.